NeilBrommer/NewTabPage
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix a bug where a group's card data wasn't updated when a group is deleted

Browse source
This commit is contained in:
Neil Brommer 2017-12-31 19:09:26 -08:00
parent 11b99d8289
commit 6f2925d0cf
1 changed files with 25 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
js/editBookmarks.js
View file

@ -32,6 +32,13 @@ function groupMoved(dropEvt) {
if (g.groupIndex > oldIndex && g.groupIndex <= newIndex) { if (g.groupIndex > oldIndex && g.groupIndex <= newIndex) {
g.groupIndex--; g.groupIndex--;
groupsStore.put(g); groupsStore.put(g);
// modify the group's card
var cardContainer = $("#group-" + (g.groupIndex + 1));
cardContainer.attr("id", "group" + g.groupIndex);
var card = $(cardContainer.children()[0]);
card.attr("data-group-index", g.groupIndex);
} }
} }
} else { // oldIndex > newIndex } else { // oldIndex > newIndex
@ -39,12 +46,28 @@ function groupMoved(dropEvt) {
if (g.groupIndex < oldIndex && g.groupIndex >= newIndex) { if (g.groupIndex < oldIndex && g.groupIndex >= newIndex) {
g.groupIndex++; g.groupIndex++;
groupsStore.put(g); groupsStore.put(g);
// modify the group's card
var cardContainer = $("#group-" + (g.groupIndex - 1));
cardContainer.attr("id", "group" + g.groupIndex);
var card = $(cardContainer.children()[0]);
card.attr("data-group-index", g.groupIndex);
} }
} }
} }
groups[oldIndex].groupIndex = newIndex; var movedGroupData = groups[oldIndex];
groupsStore.put(groups[oldIndex]);
movedGroupData.groupIndex = newIndex;
groupsStore.put(movedGroupData);
// modify the group's card
var cardContainer = $("#group-" + oldIndex);
cardContainer.attr("id", "group" + newIndex);
var card = $(cardContainer.children()[0]);
card.attr("data-group-index", newIndex);
db.close(); db.close();
} }